From 86940be22421f709107d7be8a890d67ea65c25e5 Mon Sep 17 00:00:00 2001 From: Aidan Woods Date: Sun, 8 Apr 2018 17:49:36 +0100 Subject: [PATCH] Use mutating loop instead of creating new array --- Parsedown.php | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/Parsedown.php b/Parsedown.php index eebd2f9..9b7a3e9 100644 --- a/Parsedown.php +++ b/Parsedown.php @@ -1664,26 +1664,22 @@ class Parsedown protected function elementsApplyRecursive($closure, array $Elements) { - $newElements = array(); - - foreach ($Elements as $Element) + foreach ($Elements as &$Element) { - $newElements[] = $this->elementApplyRecursive($closure, $Element); + $Element = $this->elementApplyRecursive($closure, $Element); } - return $newElements; + return $Elements; } protected function elementsApplyRecursiveDepthFirst($closure, array $Elements) { - $newElements = array(); - - foreach ($Elements as $Element) + foreach ($Elements as &$Element) { - $newElements[] = $this->elementApplyRecursiveDepthFirst($closure, $Element); + $Element = $this->elementApplyRecursiveDepthFirst($closure, $Element); } - return $newElements; + return $Elements; } protected function element(array $Element)